dgb: rewire decay constants onto share_weight_decay SSOT (#450 follow-on) - #525
Merged
Merged
Conversation
…-on) Collapse three open-coded copies of the weight-decay constants (DECAY_PRECISION/DECAY_SCALE/LN2_MICRO) and the decay_per/half_life recomputation in DensePPLNSWindow::init_decay_table, get_v36_decayed_cumulative_weights, and dump_v36_pplns_walk onto the dgb::coin::share_weight_decay SSOT helpers. Value-invariant by construction: adds DecayedCumulativeWeightVectorInvariance, a non-circular KAT that recomputes decay_per and the full iterative decayed-cumulative-weight vector from the pre-#450 literals and asserts byte-identity against the SSOT path. Fenced to src/impl/dgb/.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consumer-rewire follow-on to merged #450. Collapses three open-coded copies of the weight-decay constants (DECAY_PRECISION/DECAY_SCALE/LN2_MICRO) and the decay_per/half_life recomputation in DensePPLNSWindow (init_decay_table, get_v36_decayed_cumulative_weights, dump_v36_pplns_walk) onto the dgb::coin::share_weight_decay SSOT.
VALUE-INVARIANCE KAT (per integrator gate): DecayedCumulativeWeightVectorInvariance recomputes decay_per + the full iterative decayed-cumulative-weight vector from the pre-#450 literals (1<<40, 693147, 1e6, max(CL/4,1)) over a synthetic V36 window (CL=8640) using the same unsigned __int128 mul-shift as the hot path, and asserts byte-identity against the SSOT path. OLD path is independent of the helper under test -> NON-CIRCULAR.
ctest local 7/7 green (dgb_share_weight_decay_test), non-hollow. Fenced to src/impl/dgb/. Consensus version-switch-adjacent surface -> NO self-merge; integrator value-diffs, operator taps.